trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #890: [TRAFODION-2394] Add documentation fo...
Date Thu, 22 Dec 2016 22:16:38 GMT
GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/890

    [TRAFODION-2394] Add documentation for TO_CHAR + fix some bugs in it

    This set of changes does the following:
    
    1. Adds documentation for the TO_CHAR function to the SQL Reference Manual.
    2. Fixes four bugs:
    a. TO_CHAR(x), where x is a TIME column, would sometimes have garbage characters at the
end of it. This has been fixed.
    b. TO_CHAR(x,'YY/MM/DD') produces garbage output when x is a TIME column, because x has
no date fields. This has been fixed. A 4072 error is now raised instead.
    c. TO_CHAR(DATE '2016-03-01', 'YYYYMMDDHH24MISS') returns an incorrectly formatted value,
'2016030100:00:'. This has been fixed; it now returns the correct value '20160301000000'.
    d. DATEFORMAT(5,USA) returns an error 4071 (as it should), but the error message text
says "TO_CHAR" instead of "DATEFORMAT". This has been fixed.
    3. Updates to regression test seabase/TEST030 and its expected results to cover the bugs
above.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2394

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #890
    
----
commit 93bd6bcd1c24c779a45af55bb31898a2f1f01e2f
Author: Dave Birdsall <dbirdsall@apache.org>
Date:   2016-12-22T22:10:04Z

    [TRAFODION-2394] Add documentation for TO_CHAR + fix some bugs in it

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message