From codereview-return-4054-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.incubator.apache.org Thu Dec 8 06:19:14 2016 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 87FF1199BE for ; Thu, 8 Dec 2016 06:19:14 +0000 (UTC) Received: (qmail 49956 invoked by uid 500); 8 Dec 2016 06:19:14 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 49921 invoked by uid 500); 8 Dec 2016 06:19:14 -0000 Mailing-List: contact codereview-help@trafodion.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.incubator.apache.org Delivered-To: mailing list codereview@trafodion.incubator.apache.org Received: (qmail 49910 invoked by uid 99); 8 Dec 2016 06:19:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2016 06:19:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 65593182132 for ; Thu, 8 Dec 2016 06:19:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.018 X-Spam-Level: X-Spam-Status: No, score=-7.018 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id P1KL8l87QsqQ for ; Thu, 8 Dec 2016 06:19:12 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id EF6F85F47A for ; Thu, 8 Dec 2016 06:19:11 +0000 (UTC) Received: (qmail 49881 invoked by uid 99); 8 Dec 2016 06:19:11 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2016 06:19:11 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id EFA24E3839; Thu, 8 Dec 2016 06:19:10 +0000 (UTC) From: rwbzx To: codereview@trafodion.incubator.apache.org Reply-To: codereview@trafodion.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-trafodion pull request #871: [TRAFODION-2375]ODBC:SQLGetDiagRec re... Content-Type: text/plain Message-Id: <20161208061910.EFA24E3839@git1-us-west.apache.org> Date: Thu, 8 Dec 2016 06:19:10 +0000 (UTC) Github user rwbzx commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/871#discussion_r91451478 --- Diff: win-odbc64/odbcclient/drvr35/cdiag.cpp --- @@ -389,8 +389,8 @@ SQLRETURN CDiagRec::GetDiagRec(SQLSMALLINT RecNumber, translateLengthMax/2, (int *)&translateLength, (char *)errorMsg)) != SQL_SUCCESS ) rc = SQL_SUCCESS_WITH_INFO; //ERROR; - strLen = translateLength; - ((wchar_t *)MessageText)[strLen] = L'\0' ; + ((wchar_t *)MessageText)[translateLength] = L'\0'; + strLen = tmpStrLen; --- End diff -- Yes indeed, the logic is added in latest commit. Thanks for the tips. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---