trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #889: [TRAFODION-2408] Changes to support "...
Date Tue, 03 Jan 2017 18:26:03 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/889#discussion_r94451970
  
    --- Diff: core/sql/executor/ExExeUtil.h ---
    @@ -2970,8 +2970,92 @@ class ExExeUtilLobExtractTcb : public ExExeUtilTcb
       LOBglobals *lobGlobals_;
     };
     
    +
    +
    +//////////////////////////////////////////////////////////////////////////
    +// -----------------------------------------------------------------------
    +// ExExeUtilLobUpdateTdb
    +// -----------------------------------------------------------------------
    +class ExExeUtilLobUpdateTdb : public ComTdbExeUtilLobUpdate
    +{
    + public:
    +
    +  // ---------------------------------------------------------------------
    +  // Constructor is only called to instantiate an object used for
    +  // retrieval of the virtual table function pointer of the class while
    +  // unpacking. An empty constructor is enough.
    +  // ---------------------------------------------------------------------
    +  NA_EIDPROC ExExeUtilLobUpdateTdb()
    +    {}
    +
    +  NA_EIDPROC virtual ~ExExeUtilLobUpdateTdb()
    +    {}
    +
    +
    +  // ---------------------------------------------------------------------
    +  // Build a TCB for this TDB. Redefined in the Executor project.
    +  // ---------------------------------------------------------------------
    +  NA_EIDPROC virtual ex_tcb *build(ex_globals *globals);
    +private:
    +};
    +
    +//////////////////////////////////////////////////////////////////////////
    +// -----------------------------------------------------------------------
    +// ExExeUtilLobUpdateTcb
    +// -----------------------------------------------------------------------
    +
    +
    +class ExExeUtilLobUpdateTcb : public ExExeUtilTcb
    +{
    +  friend class ExExeUtilLobUpdateTdb;
    +  friend class ExExeUtilPrivateState;
    +
    +public:
    +  // Constructor
    +  ExExeUtilLobUpdateTcb(const ComTdbExeUtilLobUpdate & exe_util_tdb,
    +			 const ex_tcb * child_tcb, 
    +			 ex_globals * glob = 0);
    +  
    +  virtual short work();
    +  
    +  ExExeUtilLobUpdateTdb & lobTdb() const
    +  {
    +    return (ExExeUtilLobUpdateTdb &) tdb;
    +  };
    +  LOBglobals *getLobGlobals() { return lobGlobals_;}
    + protected:
    +  enum Step
    +    {
    +      EMPTY_,
    +      GET_HANDLE_,
    +      UPDATE_LOB_DATA_,
    +      EMPTY_LOB_DATA_,
    +      APPEND_LOB_DATA_,
    +      RETURN_STATUS_,
    +      DONE_,
    +      CANCEL_,
    +      HANDLE_ERROR_,
    +      CANCELLED_
    +    };
    +  Step step_;
    +  Lng32 lobHandleLen_;
    +  char  lobHandle_[2050];
    --- End diff --
    
    How are the lengths of these variables derived?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message