trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #889: [TRAFODION-2408] Changes to support "...
Date Tue, 03 Jan 2017 18:57:03 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/889#discussion_r94461094
  
    --- Diff: core/sql/exp/ExpLOBaccess.cpp ---
    @@ -1502,7 +1507,50 @@ Ex_Lob_Error ExLob::allocateDesc(ULng32 size, Int64 &descNum,
Int64 &dataOffset,
         char logBuf[4096];
         lobDebugInfo("In ExLob::allocateDesc",0,__LINE__,lobTrace_);
         Int32 openFlags = O_RDONLY ;   
    -    
    +    if (size == 0) //we are trying to empty this lob.
    +      {
    +        //rename lob datafile
    +        char * saveLobDataFile = new(getLobGlobalHeap()) char[MAX_LOB_FILE_NAME_LEN+6];
    --- End diff --
    
    This is fine. We only need to allocate for "_save" suffix
    str_sprintf(saveLobDataFile, "%s_save",lobDataFile_);


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message