trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #898: [TRAFODION-2420] RMS enhancements
Date Wed, 04 Jan 2017 13:04:03 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/898#discussion_r94578723
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/ResStatisticsStatement.cpp ---
    @@ -1265,7 +1265,7 @@ void ResStatisticsStatement::setStatistics(SRVR_STMT_HDL *pSrvrStmt,
SQLSTATS_TY
     #define MAX_PERTABLE_STATS_DESC		30
     
     #define MAX_MASTERSTATS_ENTRY		31
    -#define MAX_MEASSTATS_ENTRY			34
    +#define MAX_MEASSTATS_ENTRY			26
     #define MAX_PERTABLE_ENTRY			14
    --- End diff --
    
    Yes. Changed it.  Missed out in ODBC code but changed it in Type2 JDBC driver. I think
there is a need to share this code between all components SQL, JDBC and ODBC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message