trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sbroeder <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #885: [TRAFODION-2414] enhance 8616 commit ...
Date Wed, 04 Jan 2017 14:13:37 GMT
Github user sbroeder commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/885#discussion_r94527876
  
    --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/TransactionManager.java
---
    @@ -643,13 +644,18 @@ public CommitRequestResponse call(TrxRegionService instance) throws
IOException
                     retry = true;
                  }
                  else if(result.size() == 1){
    +               LOG.info("doPrepareX(MVCC), received result size: " + result.size() +
" for transaction "
    --- End diff --
    
    An info comment here would result in 1 message per prepare.  This should probably be a
debug message or trace. and should also have the preceding if test to see if that level is
enabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message