trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #885: [TRAFODION-2414] enhance 8616 commit ...
Date Wed, 04 Jan 2017 14:38:40 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/885#discussion_r94593238
  
    --- Diff: core/sqf/src/tm/tmlib.cpp ---
    @@ -956,13 +956,39 @@ short BEGINTX(int *pp_tag, int pv_timeout, int64 pv_type_flags)
         return lv_error;
     } //BEGINTX
     
    +//--------------------------------------------------------------------
    +//DEALLOCATE_ERR
    +//
    +//Purpose   : Called subsequent to ENDTRANSACTION_ERR
    +//Params    : none
    +//--------------------------------------------------------------------
    +void DEALLOCATE_ERR(char *&errStr)
    +{
    +  if(errStr)
    +    delete errStr;
    --- End diff --
    
    Should we set the errStr to NULL


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message