trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #898: [TRAFODION-2420] RMS enhancements
Date Wed, 04 Jan 2017 18:08:03 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/898#discussion_r94633228
  
    --- Diff: core/sql/executor/ExStats.cpp ---
    @@ -3678,9 +3292,8 @@ void ExPartitionAccessStats::getVariableStatsInfo(char * dataBuffer,
     	      "AnsiName: %s PhysName: %s BuffersSize: %u BuffersSent: %u BuffersRcvd: %u NumMessages:
%Ld MsgBytes: %Ld StatsBytes: %Ld MsgBytesSent: %Ld MsgBytesRcvd: %Ld ",
     	      ansiName_, fileName_,
     	      bufferStats()->sendBufferSize(), bufferStats()->sentBuffers().entryCnt(),
bufferStats()->recdBuffers().entryCnt(), 
    -	      fsDp2MsgsStats()->getNumMessages(),
    -	      fsDp2MsgsStats()->getMessageBytes(),
    -	      fsDp2MsgsStats()->getStatsBytes(),
    +	      exeSEStats()->getNumIOCalls(),
    +	      exeSEStats()->getNumIOBytes(),
    --- End diff --
    
    Thanks Arvind. I have fixed the issue with ExPartitionAccess::getVariableStatsInfo to
provide 0 for statsBytes.  ExPartitionAccess is not used currently. Hence, the regression
tests didn't detect this issue. Thanks for catching it. I have left ExPartitionAccess behind
because it might be resurrected later


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message