trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From svarnau <>
Subject [GitHub] incubator-trafodion pull request #906: [TRAFODION-2430] python installer - n...
Date Fri, 06 Jan 2017 07:29:59 GMT
Github user svarnau commented on a diff in the pull request:
    --- Diff: install/Makefile ---
    @@ -17,28 +17,42 @@
     RELEASE_VER ?= ${TRAFODION_VER}-incubating
     RELEASE_TYPE ?= $(shell echo $(TRAFODION_VER_PROD)| sed -e 's/ /-/g')
     INSTALLER_TARNAME = $(shell echo ${RELEASE_TYPE}_installer-${RELEASE_VER}.tar.gz |tr
'[A-Z]' '[a-z]')
    +PYINSTALLER_TARNAME = $(shell echo ${RELEASE_TYPE}_pyinstaller-${RELEASE_VER}.tar.gz
|tr '[A-Z]' '[a-z]')
    -all: pkg-installer 
    +all: pkg-installer
    -pkg-installer: installer/LICENSE installer/NOTICE installer/DISCLAIMER
    +pkg-installer: installer/LICENSE installer/NOTICE installer/DISCLAIMER \
    +               python-installer/LICENSE python-installer/NOTICE python-installer/DISCLAIMER
     	tar czf ${INSTALLER_TARNAME} installer --exclude=tools
    +	tar czf ${PYINSTALLER_TARNAME} python-installer
     	mkdir -p ../distribution
    --- End diff --
    Rather than build two tarballs in one makefile target, I think it would be cleaner to
make another target, and have all target depend on both.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message