trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #909: [TRAFODION-2433] Capture and log call...
Date Wed, 11 Jan 2017 15:14:34 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/909#discussion_r95595859
  
    --- Diff: core/sql/sqlmxevents/logmxevent_traf.cpp ---
    @@ -185,9 +187,9 @@ void SQLMXLoggingArea::logPrivMgrInfo(const char *filename,
     }
     
     
    -static void writeStackTrace(char *s, int bufLen)
    +Int32 writeStackTrace(char *s, int bufLen)
    --- End diff --
    
    Looks like buflen is not being used to limit the stack trace being copied. This can lead
to buffer overflow. 8K is too small for the deep stack we would get in Trafodion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message