trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #914: [TRAFODION-2351] Bulk load with log e...
Date Tue, 17 Jan 2017 17:21:59 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/914#discussion_r96463022
  
    --- Diff: core/sql/executor/ExExeUtilLoad.cpp ---
    @@ -1417,29 +1416,45 @@ short ExExeUtilHBaseBulkLoadTcb::work()
                   masterGlob->getStatement()->getContext()->setSqlParserFlags(0x20000);
                 }
               }
    +        ComDiagsArea *diagsArea = getDiagsArea();
     
             cliRC = cliInterface()->executeImmediate(loadQuery,
                 NULL,
                 NULL,
                 TRUE,
    -            &rowsAffected_);
    -          if (parserFlagSet)
    -            masterGlob->getStatement()->getContext()->resetSqlParserFlags(0x20000);
    +            &rowsAffected_,
    +            FALSE,
    +            diagsArea);
     
    +        if (parserFlagSet)
    +            masterGlob->getStatement()->getContext()->resetSqlParserFlags(0x20000);
             if (cliRC < 0)
             {
               rowsAffected_ = 0;
               cliInterface()->retrieveSQLDiagnostics(getDiagsArea());
               step_ = LOAD_END_ERROR_;
               break;
             }
    -        
    -        step_ = COMPLETE_BULK_LOAD_;
    +        else {
    +           step_ = COMPLETE_BULK_LOAD_;
    +           ComCondition *cond;
    +           Lng32 entryNumber;
    +           while ((cond = diagsArea->findCondition(EXE_ERROR_ROWS_FOUND, &entryNumber))
!= NULL) {
    +              errorRowCount = cond->getOptionalInteger(0);
    +              diagsArea->deleteWarning(entryNumber);
    +           }
    +           // Need to clear the diags Area to get the correct rowsAffected for the LOAD
COMPLETE command
    +           // Hence, we might lose any other warnings created at the time of loading
like error during
    +           // logging error rows
    +           diagsArea->clear();
    --- End diff --
    
    Are we saying here that some diags conditions could be lost? If yes, is there no way to
avoid this? Maybe correct rowsAffected could be copied to the appropriate diagsCondition (or
another diagsArea/condition be used a messenger to communicate the rowcount to its eventual
location?). If conditions could be lost here, I would have preferred to see something to avoid
that. Likely I just misunderstood the comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message