trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #915: [TRAFODION-2440] Replace fixed length...
Date Tue, 17 Jan 2017 22:05:46 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/915#discussion_r96522147
  
    --- Diff: core/sql/exp/ExpLOBaccess.cpp ---
    @@ -198,7 +198,7 @@ Ex_Lob_Error ExLob::fetchCursor(char *handleIn, Int32 handleLenIn,
Int64 &outOff
       lobCursors_it it = lobCursors_.find(string(handleIn, handleLenIn));
       char logBuf[4096];
       lobDebugInfo("In ExLob::fetchCursor",0,__LINE__,lobTrace_);
    -  char *blackBox = new(getLobGlobalHeap()) char[MAX_LOB_FILE_NAME_LEN+6];
    +  char *blackBox = new(getLobGlobalHeap()) char[MAX_LOB_FILE_NAME_LEN+6]; // TODO: do
we ever go this way for Hive?
       Int32 blackBoxLen = 0;
    --- End diff --
    
    This code path is taken for external LOB files. The file name could be provided by the
user in the form of file:///<path name>/.../<filename> So perhaps best to change
this too. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message