trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #913: TRAFODION-2439 add support for traf v...
Date Wed, 18 Jan 2017 18:49:55 GMT
Github user anoopsharma00 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/913#discussion_r96706601
  
    --- Diff: core/sql/optimizer/BindRelExpr.cpp ---
    @@ -13445,6 +13435,14 @@ RelExpr * GenericUpdate::bindNode(BindWA *bindWA)
       if (getOperatorType() == REL_UNARY_UPDATE ||
           getOperatorType() == REL_UNARY_DELETE) {
     
    +    if (getTableDesc()->getNATable()->isHiveTable())
    +      {
    +        *CmpCommon::diags() << DgSqlCode(-4223)
    +                            << DgString0("Update/Delete on Hive table is");
    +        bindWA->setErrStatus();
    +        return this;
    +      }
    +
    --- End diff --
    
    
    During binder phase, relational nodes are typed as REL_UNARY_UPDATE or REL_UNARY_DELETE
    for update or delete operations. Binder checks for them to determine if it is an update
or delete.
    They may later get changed to other upd/del like subset/unique/cursor etc.
    No update or delete operations are currently supported on hive tables.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message