trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #915: [TRAFODION-2440] Replace fixed length...
Date Wed, 18 Jan 2017 19:19:16 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/915#discussion_r96712914
  
    --- Diff: core/sql/exp/ExpLOBaccess.h ---
    @@ -515,7 +515,7 @@ class ExLob
     
       public:
     
    -    char lobDataFile_[MAX_LOB_FILE_NAME_LEN];
    +    string lobDataFile_; // TODO: change to NAString when ExLobCursor is allocated off
of an NAHeap
    --- End diff --
    
    Actually, it's not. See line 2338 (new file numbering):
    
    	  //lobPtr = new (lobGlobals->getHeap())ExLob();
    	  lobPtr = new ExLob();
    
    It appears that someone experimented with putting it on the executor heap and then retreated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message