trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request #915: [TRAFODION-2440] Replace fixed length...
Date Mon, 23 Jan 2017 16:21:25 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sql/exp/ExpLOBaccess.cpp ---
    @@ -2285,7 +2338,7 @@ Ex_Lob_Error ExLobsOper (
       Ex_Lob_Error err = LOB_OPER_OK;
       ExLob *lobPtr = NULL;
    -  char fn[MAX_LOB_FILE_NAME_LEN];
    +  string fn;
    --- End diff --
    Missed this one. This needs to be converted to a dynamic char array or an NAString on
the Lob globals heap.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message