trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <>
Subject [GitHub] incubator-trafodion pull request #931: [TRAFODION-2351] Bulk load with log e...
Date Thu, 26 Jan 2017 02:52:25 GMT
Github user zellerh commented on a diff in the pull request:
    --- Diff: core/sql/executor/ExExeUtilLoad.cpp ---
    @@ -1442,7 +1442,8 @@ short ExExeUtilHBaseBulkLoadTcb::work()
                ComCondition *cond;
                Lng32 entryNumber;
                while ((cond = diagsArea->findCondition(EXE_ERROR_ROWS_FOUND, &entryNumber))
!= NULL) {
    -              errorRowCount = cond->getOptionalInteger(0);
    +              if (errorRowCount < cond->getOptionalInteger(0))
    --- End diff --
    Actually, I do have one question: You mention that each warning is for a different range.
Should we add the rowcounts instead of using the max?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message