trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From narendragoyal <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #929: [TRAFODION-2455] Add retry to row cou...
Date Thu, 26 Jan 2017 05:27:36 GMT
Github user narendragoyal commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/929#discussion_r97933083
  
    --- Diff: core/sqf/monitor/linux/process.cxx ---
    @@ -1317,7 +1318,11 @@ bool CProcess::Create (CProcess *parent, int & result)
         env = getenv ("TERM");
         STRCPY (term, (env?env:"ansi"));
         env = getenv ("TZ");
    -    STRCPY (tz, (env?env:""));
    +    tz_exists = (env != NULL);
    +    if (tz_exists)
    +    {
    +      STRCPY (tz, env); // see note regarding TZ below
    +    }
         env = getenv ("USER");
         STRCPY (user, (env?env:""));
         env = getenv ("HOME");
    --- End diff --
    
    Thanks Dave for this find! Requesting @zcorrea also to take a look at the process.cxx
changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message