trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #916: TRAFODION-2442 timestamp/date compari...
Date Tue, 17 Jan 2017 18:54:42 GMT
GitHub user anoopsharma00 opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/916

    TRAFODION-2442  timestamp/date comparison bug. And couple other fixes.

    -- TRAFODION-2442 timestamp comparison with date returns incorrect results.
      that has been fixed. Date value is expanded to timestamp datatype and
      then compared.
      Fix is for timestamp/date comparison only.
      TIMESTAMP comparison to TIME, and DATE comparison to TIME is not allowed.
    
    -- row length of aligned format tables is now calculated correctly and
      stored in metadata.
    
    -- optimizer cost method for sort had a high limit of MEMORY_UNITS_SIZE
       default set to 20M. For large rows in the range of 10 Mb,
       this caused an overflow.
       Fix is to allocate space for MAXOF default and size of 2 rows.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anoopsharma00/incubator-trafodion ansharma_trafr21_br

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #916
    
----
commit fe46974da6feb2bf5ba675f1622b07b7ae503a01
Author: Anoop Sharma <anoop.sharma@esgyn.com>
Date:   2017-01-17T18:50:25Z

    TRAFODION-2442  timestamp/date comparison bug. And couple other fixes.
    
    -- TRAFODION-2442 timestamp comparison with date returns incorrect results.
      that has been fixed. Date value is expanded to timestamp datatype and
      then compared.
      Fix is for timestamp/date comparison only.
      TIMESTAMP comparison to TIME, and DATE comparison to TIME is not allowed.
    
    -- row length of aligned format tables is now calculated correctly and
      stored in metadata.
    
    -- optimizer cost method for sort had a high limit of MEMORY_UNITS_SIZE
       default set to 20M. For large rows in the range of 10 Mb,
       this caused an overflow.
       Fix is to allocate space for MAXOF default and size of 2 rows.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message