trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #938: [TRAFODION-2465] Fix two bugs
Date Mon, 30 Jan 2017 19:06:34 GMT
GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/938

    [TRAFODION-2465] Fix two bugs

    This set of changes fixes two problems (both introduced by me):
    
    1. When UPDATE STATISTICS retries a statement, and the statement continues to fail, the
error diagnostics are incorrect. The root cause of the error is not reported, and some irrelevant
errors are reported (i.e. 8609, error on transaction rollback, which happens because the Executor
sometimes has already rolled back the transaction when UPDATE STATISTICS attempts a ROLLBACK
after a statement failure). This bug was introduced when I rewrote the retry logic in JIRA
TRAFODION-2341. My unit test was not thorough enough. (ustat/hs_cli.cpp)
    2. Performing UPDATE STATISTICS ON EXISTING COLUMNS PERSISTENT would fail on Hive tables
with varchar columns over 200000 characters long. I fixed a similar issue in JIRA TRAFODION-2322,
but failed to notice that this issue existed separately in the ON EXISTING COLUMNS code path.
(ustat/hs_parser.cpp).


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2465

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/938.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #938
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message