trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #940: [TRAFODION-2457] Re-enable compGenera...
Date Tue, 31 Jan 2017 17:54:49 GMT
GitHub user zellerh opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/940

    [TRAFODION-2457] Re-enable compGeneral/TEST042 and try to stabilize

    Implemented suggestions made by Suresh and Selva. Suresh found out
    that the test gives different results when authorization is
    initialized, and that caused problems because it is usually
    initialized on developer workstations but not on Jenkins.
    
    Suresh and Selva suggested to suppress the key length, since that can
    vary with different CQD settings like SCHEMA.
    
    Added the queries to the log and expected files to see whether that
    will make failure diagnosis easier. The queries get filtered out, so
    should not cause test failures.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zellerh/incubator-trafodion bug/cses_jan-17

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #940
    
----
commit 715d8b05e14b825be4da83ec7d329b2d07cd7ece
Author: Hans Zeller <hzeller@apache.org>
Date:   2017-01-31T17:33:00Z

    [TRAFODION-2457] Re-enable compGeneral/TEST042 and try to stabilize
    
    Implemented suggestions made by Suresh and Selva. Suresh found out
    that the test gives different results when authorization is
    initialized, and that caused problems because it is usually
    initialized on developer workstations but not on Jenkins.
    
    Suresh and Selva suggested to suppress the key length, since that can
    vary with different CQD settings like SCHEMA.
    
    Added the queries to the log and expected files to see whether that
    will make failure diagnosis easier. The queries get filtered out, so
    should not cause test failures.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message