From codereview-return-4184-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.incubator.apache.org Wed Jan 4 14:13:42 2017 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3CABF1928A for ; Wed, 4 Jan 2017 14:13:42 +0000 (UTC) Received: (qmail 21394 invoked by uid 500); 4 Jan 2017 14:13:42 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 21354 invoked by uid 500); 4 Jan 2017 14:13:42 -0000 Mailing-List: contact codereview-help@trafodion.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.incubator.apache.org Delivered-To: mailing list codereview@trafodion.incubator.apache.org Received: (qmail 21343 invoked by uid 99); 4 Jan 2017 14:13:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2017 14:13:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 81AB81A003A for ; Wed, 4 Jan 2017 14:13:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Rrxm4JMLXSoZ for ; Wed, 4 Jan 2017 14:13:39 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 7C7765FBEE for ; Wed, 4 Jan 2017 14:13:38 +0000 (UTC) Received: (qmail 21298 invoked by uid 99); 4 Jan 2017 14:13:37 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2017 14:13:37 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A5012DF9E5; Wed, 4 Jan 2017 14:13:37 +0000 (UTC) From: sbroeder To: codereview@trafodion.incubator.apache.org Reply-To: codereview@trafodion.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-trafodion pull request #885: [TRAFODION-2414] enhance 8616 commit ... Content-Type: text/plain Message-Id: <20170104141337.A5012DF9E5@git1-us-west.apache.org> Date: Wed, 4 Jan 2017 14:13:37 +0000 (UTC) Github user sbroeder commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/885#discussion_r94527876 --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/client/transactional/TransactionManager.java --- @@ -643,13 +644,18 @@ public CommitRequestResponse call(TrxRegionService instance) throws IOException retry = true; } else if(result.size() == 1){ + LOG.info("doPrepareX(MVCC), received result size: " + result.size() + " for transaction " --- End diff -- An info comment here would result in 1 message per prepare. This should probably be a debug message or trace. and should also have the preceding if test to see if that level is enabled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---