From codereview-return-4243-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.incubator.apache.org Tue Jan 17 17:33:15 2017 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C61FD19938 for ; Tue, 17 Jan 2017 17:33:15 +0000 (UTC) Received: (qmail 10133 invoked by uid 500); 17 Jan 2017 17:33:15 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 10098 invoked by uid 500); 17 Jan 2017 17:33:15 -0000 Mailing-List: contact codereview-help@trafodion.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.incubator.apache.org Delivered-To: mailing list codereview@trafodion.incubator.apache.org Received: (qmail 10086 invoked by uid 99); 17 Jan 2017 17:33:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2017 17:33:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 16F81C24E9 for ; Tue, 17 Jan 2017 17:33:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rHLcdsvDFvL5 for ; Tue, 17 Jan 2017 17:33:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id DBE595FB5B for ; Tue, 17 Jan 2017 17:33:13 +0000 (UTC) Received: (qmail 9190 invoked by uid 99); 17 Jan 2017 17:32:35 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2017 17:32:35 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B0C56DFB0E; Tue, 17 Jan 2017 17:32:35 +0000 (UTC) From: sureshsubbiah To: codereview@trafodion.incubator.apache.org Reply-To: codereview@trafodion.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-trafodion pull request #914: [TRAFODION-2351] Bulk load with log e... Content-Type: text/plain Message-Id: <20170117173235.B0C56DFB0E@git1-us-west.apache.org> Date: Tue, 17 Jan 2017 17:32:35 +0000 (UTC) Github user sureshsubbiah commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/914#discussion_r96465258 --- Diff: core/sql/regress/hive/EXPECTED015 --- @@ -1571,6 +1582,7 @@ Task: CLEANUP Status: Ended Time: 2016-12-11 01:58:54.934 Task: CLEANUP Status: Ended Elapsed Time: 00:00:00.682 Task: LOADING DATA Status: Started Time: 2016-12-11 01:58:54.934 Rows Processed: 5000 + Error Rows: 0 --- End diff -- A few tests with error rows will be nice. Some of the current tests with 0 errors could be altered to have error rows, that way total time taken to run the test will not increase much. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---