From codereview-return-4304-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.incubator.apache.org Thu Jan 26 05:28:13 2017 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 63D861979E for ; Thu, 26 Jan 2017 05:28:13 +0000 (UTC) Received: (qmail 13835 invoked by uid 500); 26 Jan 2017 05:28:12 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 13800 invoked by uid 500); 26 Jan 2017 05:28:12 -0000 Mailing-List: contact codereview-help@trafodion.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.incubator.apache.org Delivered-To: mailing list codereview@trafodion.incubator.apache.org Received: (qmail 13789 invoked by uid 99); 26 Jan 2017 05:28:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2017 05:28:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id F0484C1805 for ; Thu, 26 Jan 2017 05:28:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.018 X-Spam-Level: X-Spam-Status: No, score=-7.018 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xIMgtu2XO1UB for ; Thu, 26 Jan 2017 05:28:11 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id DA1E55F3BF for ; Thu, 26 Jan 2017 05:28:10 +0000 (UTC) Received: (qmail 13294 invoked by uid 99); 26 Jan 2017 05:27:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2017 05:27:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2856EDFA69; Thu, 26 Jan 2017 05:27:36 +0000 (UTC) From: narendragoyal To: codereview@trafodion.incubator.apache.org Reply-To: codereview@trafodion.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-trafodion pull request #929: [TRAFODION-2455] Add retry to row cou... Content-Type: text/plain Message-Id: <20170126052736.2856EDFA69@git1-us-west.apache.org> Date: Thu, 26 Jan 2017 05:27:36 +0000 (UTC) Github user narendragoyal commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/929#discussion_r97933083 --- Diff: core/sqf/monitor/linux/process.cxx --- @@ -1317,7 +1318,11 @@ bool CProcess::Create (CProcess *parent, int & result) env = getenv ("TERM"); STRCPY (term, (env?env:"ansi")); env = getenv ("TZ"); - STRCPY (tz, (env?env:"")); + tz_exists = (env != NULL); + if (tz_exists) + { + STRCPY (tz, env); // see note regarding TZ below + } env = getenv ("USER"); STRCPY (user, (env?env:"")); env = getenv ("HOME"); --- End diff -- Thanks Dave for this find! Requesting @zcorrea also to take a look at the process.cxx changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---