From codereview-return-4239-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.incubator.apache.org Tue Jan 17 17:15:31 2017 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7124A19819 for ; Tue, 17 Jan 2017 17:15:31 +0000 (UTC) Received: (qmail 60307 invoked by uid 500); 17 Jan 2017 17:15:31 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 60260 invoked by uid 500); 17 Jan 2017 17:15:31 -0000 Mailing-List: contact codereview-help@trafodion.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.incubator.apache.org Delivered-To: mailing list codereview@trafodion.incubator.apache.org Received: (qmail 60190 invoked by uid 99); 17 Jan 2017 17:15:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2017 17:15:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7135FC1624 for ; Tue, 17 Jan 2017 17:15:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id L8ZSu5w6c0nY for ; Tue, 17 Jan 2017 17:15:27 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id BE2835FB5D for ; Tue, 17 Jan 2017 17:15:26 +0000 (UTC) Received: (qmail 59992 invoked by uid 99); 17 Jan 2017 17:15:26 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2017 17:15:26 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DF93DDFADC; Tue, 17 Jan 2017 17:15:25 +0000 (UTC) From: DaveBirdsall To: codereview@trafodion.incubator.apache.org Reply-To: codereview@trafodion.incubator.apache.org Message-ID: Subject: [GitHub] incubator-trafodion pull request #915: [TRAFODION-2440] Replace fixed length... Content-Type: text/plain Date: Tue, 17 Jan 2017 17:15:25 +0000 (UTC) GitHub user DaveBirdsall opened a pull request: https://github.com/apache/incubator-trafodion/pull/915 [TRAFODION-2440] Replace fixed length buffers with strings in LOB code The LOB code has two uses: 1. To read and write LOB column values in Trafodion tables 2. To read Hive files into the Trafodion executor The LOB code made use of fixed length buffers to store LOB file names. Unfortunately these are too short in general for use with Hive files. Rather than simply make them longer, I have replaced these fixed length buffers with string data types in most places in the code. Some design notes: The LOB code is in the middle of a slow transition from using STL classes and the global heap to using the Trafodion NAHeap classes and heaps for memory management. Where a LOB class uses the STL heap, I replaced its fixed length buffer members with an STL string. Where a LOB class uses NAHeap, I used a Trafodion NAString instead. In one place I left the fixed length buffer alone: I did this where the LOB code calls the CLI function SQL_EXEC_LOBcliInterface. It appears that this code path is traversed only for LOB column values. (If anyone knows otherwise, please comment.) You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2440 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafodion/pull/915.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #915 ---- commit 49498dfdf6b629bf349f9630fdb5ceb197e93bf9 Author: Dave Birdsall Date: 2017-01-17T17:07:11Z [TRAFODION-2440] Replace fixed length buffers with strings in LOB code ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---