trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #943: [TRAFODION-2470] Fixed one cause of 6...
Date Thu, 02 Feb 2017 03:08:44 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/943#discussion_r99046155
  
    --- Diff: core/sql/parser/SqlParserAux.cpp ---
    @@ -863,8 +863,7 @@ ItemExpr *literalOfNumericPassingScale(NAString *strptr, char sign,
       } else if (strSize <= 19) {
         datatype = (createSignedDatatype ? REC_BIN64_SIGNED : REC_BIN64_UNSIGNED);
         length = sizeof(Int64);
    -  } else if (strSize == 20) {
    -    createSignedDatatype = FALSE;
    +  } else if ((strSize == 20) && (!createSignedDatatype)) {
    --- End diff --
    
    This is in the surround, but I wonder whether we shouldn't also look at the TRAF_LARGEINT_UNSIGNED_IO
CQD and only generate unsigned largeint literals if that CQD is set to ON.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message