trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #946: TRAFODION-1562 Enable Vsbb upsert for...
Date Tue, 07 Feb 2017 23:38:53 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/946#discussion_r99958672
  
    --- Diff: core/sql/optimizer/BindRelExpr.cpp ---
    @@ -10600,34 +10600,45 @@ Upsert is also converted into merge when TRAF_UPSERT_MODE is
set to MERGE and
     there are omitted cols with default values in case of aligned format table or 
     omitted current timestamp cols in case of non-aligned row format
     */
    -NABoolean Insert::isUpsertThatNeedsMerge(NABoolean isAlignedRowFormat, NABoolean omittedDefaultCols,
    -                                   NABoolean omittedCurrentDefaultClassCols) const
    +NABoolean Insert::isUpsertThatNeedsTransformation(NABoolean isAlignedRowFormat, 
    +                                                  NABoolean omittedDefaultCols,
    +                                                  NABoolean omittedCurrentDefaultClassCols,
    +                                                  NABoolean &toMerge) const
    --- End diff --
    
    You've added a parameter to return more information from this function. This is fine.
Another way to do it is to change the return type from NABoolean to an enum, then no added
parameter would be needed. But this is just a matter of taste; it may or may not be more convenient
for the caller.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message