trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #946: TRAFODION-1562 Enable Vsbb upsert for...
Date Wed, 08 Feb 2017 04:55:24 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/946#discussion_r99991927
  
    --- Diff: core/sql/executor/ExHbaseIUD.cpp ---
    @@ -912,8 +912,22 @@ ExWorkProcRetcode ExHbaseAccessUpsertVsbbSQTcb::work()
     	    copyRowIDToDirectBuffer(rowId_);
     
     	    currRowNum_++;
    -	    matches_++;
    -
    +            // temp code below.WIll remove the envvar after this
    +            //has got enough exposure in  testing.
    +            if (getenv("TURN_OFF_RETURNROW")) 
    --- End diff --
    
    Thanks - I will remove this. I had used it for quick debugging. I didn't realize it'll
have an impact on performance.  Will look into fixing it and submit a new version of this
file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message