trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #946: TRAFODION-1562 Enable Vsbb upsert for...
Date Wed, 08 Feb 2017 18:28:53 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/946#discussion_r100134742
  
    --- Diff: core/sql/executor/ExHbaseIUD.cpp ---
    @@ -1620,21 +1685,20 @@ ExWorkProcRetcode ExHbaseAccessBulkLoadPrepSQTcb::work()
           {
     	if (qparent_.up->isFull())
     	      return WORK_OK;
    -	    
    +
     	if (returnUpdateExpr())
     	{
    -	  ex_queue_entry * up_entry = qparent_.up->getTailEntry();
    -	  
    -	  // allocate tupps where returned rows will be created
    -	  if (allocateUpEntryTupps(
    -				   -1,
    -				   0,
    -				   hbaseAccessTdb().returnedTuppIndex_,
    -				   hbaseAccessTdb().returnUpdatedRowLen_,
    -				   FALSE,
    -				   &rc))
    +	  ex_queue_entry * up_entry = qparent_.up->getTailEntry();	 
     	    return rc;
    -	  
    +            // allocate tupps where returned rows will be created
    +            if (allocateUpEntryTupps(
    --- End diff --
    
    This statement can't be reached because of the return at 1692.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message