trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #946: TRAFODION-1562 Enable Vsbb upsert for...
Date Wed, 08 Feb 2017 19:40:16 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/946#discussion_r100151468
  
    --- Diff: core/sql/executor/ExHbaseIUD.cpp ---
    @@ -1042,7 +1104,10 @@ ExWorkProcRetcode ExHbaseAccessUpsertVsbbSQTcb::work()
     
     		numRetries_++;
     		return WORK_CALL_AGAIN;
    -	      }
    +                
    +                step_ = PROCESS_INSERT_AND_CLOSE;
    --- End diff --
    
    Yes . Not needed. We transition to PROCESS_INSERT_AND_CLOSE only after 3 tries. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message