trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #946: TRAFODION-1562 Enable Vsbb upsert for...
Date Thu, 09 Feb 2017 00:26:48 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/946#discussion_r100203386
  
    --- Diff: core/sql/generator/GenRelUpdate.cpp ---
    @@ -2855,8 +2859,8 @@ short HbaseInsert::codeGen(Generator *generator)
                setVsbbInsert(TRUE);
           }
     
    -      if ((isUpsert()) &&
    -	  (getInsertType() == Insert::UPSERT_LOAD))
    +      
    +        if (getInsertType() == Insert::UPSERT_LOAD)
    --- End diff --
    
    Just to make sure I understand: You removed the isUpsert() here because you know that
for upserts that are VSBB inserts, the insert type is UPSERT_LOAD?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message