trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prashanth-vasudev <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #953: [TRAFODION-2478] Reduce the number of...
Date Mon, 13 Feb 2017 17:42:35 GMT
Github user prashanth-vasudev commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/953#discussion_r100663267
  
    --- Diff: core/sql/bin/ex_esp_main.cpp ---
    @@ -357,15 +357,18 @@ Int32 runESP(Int32 argc, char** argv, GuaReceiveFastStart *guaReceiveFastStart)
       cliGlobals->initiateDefaultContext();
       NAHeap *espIpcHeap = cliGlobals->getIpcHeap();
       IpcEnvironment *ipcEnvPtr = cliGlobals->getEnvironment();
    -  //
    -  // Start the  memory monitor for dynamic memory management
    -  Lng32 memMonitorWindowSize = 10;
    -  Lng32 memMonitorSampleInterval = 10;
    -  MemoryMonitor memMonitor(memMonitorWindowSize,
    +  if (statsGlobals != NULL)
    +     cliGlobals->setMemoryMonitor(statsGlobals->getMemoryMonitor());
    +  else 
    +  {
    +     // Start the  memory monitor for dynamic memory management
    +     Lng32 memMonitorWindowSize = 10;
    +     Lng32 memMonitorSampleInterval = 10;
    +     MemoryMonitor memMonitor(memMonitorWindowSize,
    --- End diff --
    
    Should this allocation be made with espExecutorHeap?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message