trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #943: [TRAFODION-2470] Fixed one cause of 6...
Date Thu, 02 Feb 2017 00:52:55 GMT
GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/943

    [TRAFODION-2470] Fixed one cause of 6004 warnings

    The function literalOfNumericPassingScale (parser/SqlParserAux.cpp) is used to parse literals
into ConstValue nodes and encoded values. It was incorrectly handling signed numeric literals
of 20 characters in length: it would encode these as an unsigned 64-bit integer, then create
a signed SQLLargeInt or SQLNumeric with that unsigned encoded value. One symptom of this is
that histograms for NUMERIC datatypes would encounter 6004 errors (out-of-order histogram
intervals) if there were some values requiring less than 20 characters and others requiring
20 or more.
    
    The fix here reverts to using SQLBigNum instead for such values. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion Trafodion2470

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #943
    
----
commit 24e93d859ccd03b9a1892aef2e63bf7606f39675
Author: Dave Birdsall <dbirdsall@apache.org>
Date:   2017-02-02T00:47:55Z

    [TRAFODION-2470] Fixed one cause of 6004 warnings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message