Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/953#discussion_r100893208
  
    --- Diff: core/sql/cli/memorymonitor.cpp ---
    @@ -102,12 +102,18 @@ MemoryMonitor::MemoryMonitor(Lng32 windowSize,
     {
       // if the windowSize is 0, we do not need memory monitor.
       assert(windowSize);
    -  char buffer[1024];
    +  char buffer[2048];
       char *currPtr;
       size_t bytesRead;
       fd_meminfo_ = fopen("/proc/meminfo", "r");
       if (fd_meminfo_) {
    -    bytesRead = fread(buffer, 1, 1024, fd_meminfo_);
    +    bytesRead = fread(buffer, 1, 2048, fd_meminfo_);
    --- End diff --
    
    I see. This is my favorite way of doing it for char arrays that are used in methods like snprintf and fread here. Just a style comment, please feel free to ignore, no need for a change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---