From codereview-return-4443-apmail-trafodion-codereview-archive=trafodion.apache.org@trafodion.incubator.apache.org Thu Feb 16 08:12:57 2017 Return-Path: X-Original-To: apmail-trafodion-codereview-archive@minotaur.apache.org Delivered-To: apmail-trafodion-codereview-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1AB9219840 for ; Thu, 16 Feb 2017 08:12:57 +0000 (UTC) Received: (qmail 22262 invoked by uid 500); 16 Feb 2017 08:12:57 -0000 Delivered-To: apmail-trafodion-codereview-archive@trafodion.apache.org Received: (qmail 22226 invoked by uid 500); 16 Feb 2017 08:12:57 -0000 Mailing-List: contact codereview-help@trafodion.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: codereview@trafodion.incubator.apache.org Delivered-To: mailing list codereview@trafodion.incubator.apache.org Received: (qmail 22215 invoked by uid 99); 16 Feb 2017 08:12:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Feb 2017 08:12:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 510C1C05D7 for ; Thu, 16 Feb 2017 08:12:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.018 X-Spam-Level: X-Spam-Status: No, score=-7.018 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id WeMrhIzQFoaL for ; Thu, 16 Feb 2017 08:12:55 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id F0B175F19B for ; Thu, 16 Feb 2017 08:12:54 +0000 (UTC) Received: (qmail 22200 invoked by uid 99); 16 Feb 2017 08:12:54 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Feb 2017 08:12:54 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 03524DFB0E; Thu, 16 Feb 2017 08:12:53 +0000 (UTC) From: mkby To: codereview@trafodion.incubator.apache.org Reply-To: codereview@trafodion.incubator.apache.org Message-ID: Subject: [GitHub] incubator-trafodion pull request #964: [TRAFODION-2487] pyinstaller - error ... Content-Type: text/plain Date: Thu, 16 Feb 2017 08:12:53 +0000 (UTC) GitHub user mkby opened a pull request: https://github.com/apache/incubator-trafodion/pull/964 [TRAFODION-2487] pyinstaller - error handling home_dir variable Avoid using cfgs directly in line 501 `if` statement, don't make the key avaiable in the dict. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mkby/incubator-trafodion 2487 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-trafodion/pull/964.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #964 ---- commit ff4421d7d0245c3e2b834e2c5998d12deb4173a3 Author: Eason Date: 2017-02-16T08:07:16Z [TRAFODION-2487] pyinstaller - error handling home_dir variable ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---