trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1081: [TRAFODION-2604] sort merge phase me...
Date Wed, 03 May 2017 17:54:23 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1081#discussion_r114610600
  
    --- Diff: core/sql/executor/ex_sort.cpp ---
    @@ -218,7 +304,8 @@ ExSortTcb::ExSortTcb(const ExSortTdb & sort_tdb,
       sortStats_ = NULL;
       childTcb_ = &child_tcb;
     
    -  CollHeap * space = glob->getSpace();
    +  //Create heap to be used by sort.
    +  sortHeap_ = new(getHeap()) NAHeap("Sort Heap", (NAHeap *)getHeap(), 204800);
    --- End diff --
    
    Isn't there a SORT_MAX_HEAP_SIZE_MB CQD ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message