trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zcorrea <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1077: Trafodion 2001
Date Sun, 07 May 2017 21:29:53 GMT
Github user zcorrea commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1077#discussion_r115154601
  
    --- Diff: core/sqf/sql/scripts/sqnodestatus ---
    @@ -26,12 +26,11 @@
     # Implements:
     #   ssh -M "ConnectTimeout 1" -o "ConnectionAttempts 3" n028 hostinfo 2>&1
     #
    -# Uses:
    -#   export MY_NODES=' -w n028 -w n044 -w n029 -w n045 -w n030 -w n031 -w n032 '
    +# Uses the following enviroment variables:
     #   export SQ_MON_SSH_OPTIONS=' -o "ConnectTimeout 1" -o "ConnectionAttempts 3" '
     #
     
    -my $node_context=lc(readpipe("echo \$NODE_LIST"));
    +my $node_context=readpipe("trafconf -name");
    --- End diff --
    
    The upper lower case is addressed in other code. Specifically, in the monitor code. The
trafconf utility is new and was created to address the need of obtaining the current hostname
(node name) membership in a Trafodion cluster instance. I will add more details to its purpose
and usage in the JIRA: TRAFODION-2001. A brief summary is as follows:
    
    - Node membership is initially derived from 'sqconfig' and used to populate the Trafodion
Configuration database. After this, node membership is through the 'shell' node add/delete
commands.
    - The Trafodion Configuration database is the configuration of record once the instance
is started.
    - The 'trafconf' utility reads the contents of the Trafodion Configuration database to
display the current node membership of the cluster.
    - The 'trafconf' utility us used by scripts and by the Trafodion user .bashrc to populate
environment variables with the current node membership. Specifically, the MY_NODES environment
variable.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message