trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mkby <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1077: Trafodion 2001
Date Mon, 08 May 2017 07:33:55 GMT
Github user mkby commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1077#discussion_r115188436
  
    --- Diff: core/sqf/sql/scripts/sqnodestatus ---
    @@ -26,12 +26,11 @@
     # Implements:
     #   ssh -M "ConnectTimeout 1" -o "ConnectionAttempts 3" n028 hostinfo 2>&1
     #
    -# Uses:
    -#   export MY_NODES=' -w n028 -w n044 -w n029 -w n045 -w n030 -w n031 -w n032 '
    +# Uses the following enviroment variables:
     #   export SQ_MON_SSH_OPTIONS=' -o "ConnectTimeout 1" -o "ConnectionAttempts 3" '
     #
     
    -my $node_context=lc(readpipe("echo \$NODE_LIST"));
    +my $node_context=readpipe("trafconf -name");
    --- End diff --
    
    looks good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message