trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1087: [TRAFODION-2420] RMS enhancements
Date Tue, 09 May 2017 21:02:44 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1087#discussion_r115593353
  
    --- Diff: core/sql/executor/ex_hash_grby.h ---
    @@ -302,6 +312,7 @@ NA_EIDPROC
       void resetClusterAndReadFromChild(); // Tmobile.
     
     public:
    +  static const char *HashGrbyPhaseStr[];
    --- End diff --
    
    Minor comment: One way to avoid the static, global variable would be to use a method that
returns a constant rather than this array.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message