trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1087: [TRAFODION-2420] RMS enhancements
Date Tue, 09 May 2017 21:54:22 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1087#discussion_r115612077
  
    --- Diff: core/sql/executor/ex_hash_grby.h ---
    @@ -302,6 +312,7 @@ NA_EIDPROC
       void resetClusterAndReadFromChild(); // Tmobile.
     
     public:
    +  static const char *HashGrbyPhaseStr[];
    --- End diff --
    
    That's correct. Static global variables are also thread safe and I am hoping these phases
are not changed forever and hence it shouldn't be error prone.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message