trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1159: [TRAFODION-2674] Create index sees e...
Date Mon, 03 Jul 2017 16:58:41 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1159#discussion_r125329545
  
    --- Diff: core/sql/sqlcomp/nadefaults.cpp ---
    @@ -2839,7 +2839,7 @@ SDDkwd__(ISO_MAPPING,           (char *)SQLCHARSETSTRING_ISO88591),
       DD_____(PCODE_DEBUG_LOGDIR,        ""  ), // Pathname of log directory for PCode work
       DDint__(PCODE_EXPR_CACHE_CMP_ONLY, "0" ), // PCode Expr Cache compare-only mode
       DDint__(PCODE_EXPR_CACHE_DEBUG,    "0" ), // PCode Expr Cache debug (set to 1 to enable
dbg logging)
    -  DDint__(PCODE_EXPR_CACHE_ENABLED,  "1" ), // PCode Expr Cache Enabled (set to 0 to
disable the cache)
    +  DDint__(PCODE_EXPR_CACHE_ENABLED,  "0" ), // PCode Expr Cache Enabled (set to 0 to
disable the cache)
    --- End diff --
    
    On EXPECTED023, I was trying to change the text of an error message which incorrectly
had the default schema as SEABASE instead of SCH. But I think that change had already been
made (between the time I checked out and created this PR). Instead of my actual change, these
DIFFs now show all the timestamp differences that are likely handled by the FILTER? I was
not aware of the issue  in HSTable::makeSampleName. Thank you for explaining.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message