trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mkby <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1152: [TRAFODION-2658] pyinstaller - suppo...
Date Tue, 04 Jul 2017 00:45:54 GMT
Github user mkby commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1152#discussion_r125371611
  
    --- Diff: core/sqf/sql/scripts/sqregen ---
    @@ -41,8 +41,15 @@ function Usage {
     
     function RegenConfig {
         echo "Regenerating Trafodion configuration: $SQCONFIG_FILE"
    +    cd $TRAF_HOME/sql/scripts
         ./regensq.pl $SQCONFIG_FILE
    -    exit $?;
    +    if [ $? != 0 ]; then
    +        echo "Failed to run regensq.pl."
    +        exit $?
    +    fi
    +    echo "Copying Trafodion configuration file $SQCONFIG_FILE to all nodes"
    +    pdcp `trafconf -wname` $SQCONFIG_FILE $TRAF_HOME/sql/scripts/
    --- End diff --
    
    I think pdcp itself will show the error message if fails


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message