trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xwq <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1167: [TRAFODION-2308]JDBC support insert ...
Date Fri, 07 Jul 2017 06:57:06 GMT
Github user xwq commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1167#discussion_r126080717
  
    --- Diff: core/sql/exp/ExpLOBinterface.cpp ---
    @@ -728,9 +728,9 @@ Lng32 ExpLOBInterfaceUpdate(void * exLobGlob,
       Ex_Lob_Error status;
       Int64 cliError = -1;
       Int64 sourceLen = 0;
    -  if((so == Lob_Memory) || (so == Lob_External_File))
    +  if(so == Lob_External_File)
         sourceLen = strlen(srcLobData);
    -  else if (so == Lob_Buffer)
    +  else if ((so == Lob_Buffer) || (so == Lob_Memory))
    --- End diff --
    
    I have run the regression test in sql/regress, it passed.  Here the problem is the CLOB
will be truncate by '\0'.  Some charset, it uses 2 or more bytes for one character, one of
the byte may be '\0'.   It seems the tgtLobLen is the real length. Could you help me to check
it and give me some suggestions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message