trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1175: TRAFODION-2686 fix setCurSorName doe...
Date Mon, 17 Jul 2017 14:28:26 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1175#discussion_r127723191
  
    --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4Statement.java ---
    @@ -1247,7 +1247,7 @@ void setMultipleResultSets(int num_result_sets, TrafT4Desc[][] output_descriptor
     			if (desc == null) {
     				resultSet_[i] = null;
     			} else {
    -				resultSet_[i] = new TrafT4ResultSet(this, desc, stmt_labels[i], true);
    +				resultSet_[i] = new TrafT4ResultSet(this, desc, stmt_labels[i], this.sqlStmtType_==TRANSPORT.TYPE_CALL);
    --- End diff --
    
    The last parameter  seems to denote oldDataFormat in TrafT4ResultSet.java.  Can you please
provide some explanation about this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message