trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1180: [TRAFODION-2685] int type doesnot ch...
Date Mon, 17 Jul 2017 14:35:42 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1180#discussion_r127725164
  
    --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4ResultSet.java ---
    @@ -1372,7 +1372,7 @@ public long getLong(int columnIndex) throws SQLException {
     						}
     					} else {
     						throw TrafT4Messages.createSQLException(connection_.props_, connection_.getLocale(),
    -								"numeric_out_of_range", null);
    +								"numeric_out_of_range", bd.longValue());
    --- End diff --
    
    Will the longValue convert the bd into  a proper long value? Should we display the original
bd value instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message