trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1169: [TRAFODION-2680] Add CSV_FORMAT func...
Date Mon, 17 Jul 2017 16:43:43 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1169#discussion_r127759569
  
    --- Diff: core/sql/optimizer/BindItemExpr.cpp ---
    @@ -10851,6 +10851,96 @@ ItemExpr *ZZZBinderFunction::bindNode(BindWA *bindWA)
           }
         break;
     
    +    case ITM_CSV_FORMAT:
    +      {
    +	bindChildren(bindWA);
    +	if (bindWA->errStatus()) 
    +	  return this;
    +
    +        // The way the arguments of CSV_FORMAT are represented in
    +        // the parse tree is as a tree of ItemList nodes; so
    +        // CSV_FORMAT(a,b,c,d) is represented as
    +        //
    +        //    this
    +        //    /  \
    +        //   a   ItemList
    +        //         /  \
    +        //        b   ItemList
    +        //              /  \
    +        //             c    d
    +        //
    +        // The code below traverses accordingly.
    --- End diff --
    
    Thank you, Hans. Will use that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message