trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1179: Few fixes, details listed below.
Date Fri, 14 Jul 2017 04:19:06 GMT
GitHub user anoopsharma00 opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/1179

    Few fixes, details listed below.

    -- fix an issue where multiple values inserted from a list would return
      error but each value inserted on its own would succeed.
      ex: create table ts (a timestamp);
          insert into ts values ('2017-01-01 10:10:10'), ('2018-01-01 10:10:10');
    
    -- sometimes errors returned from child during hive inserts were not
       being returned. That has been fixed.
    
    -- TRAFODION-2683 extension.
       added a 'p' (prune) option which would cleanse and filter unneeded
       explain output. This helps in reducing output especially
       for larger explains.
    Ex:
    >>explain option 'p' select * from dual;
    
    ------------------------------------------------------ PLAN SUMMARY
    STATEMENT_NAME ........... NOT NAMED
    STATEMENT ................ select * from dual;
    
    ------------------------------------------------------- NODE LISTING
    ROOT ======================================  SEQ_NO 2    ONLY CHILD 1
    DESCRIPTION
      fragment_id ............ 0
      parent_frag ............ (none)
      fragment_type .......... master
      xn_access_mode ......... read_only
      auto_query_retry ....... enabled
      embedded_arkcmp ........ used
      select_list ............ %(0)
      input_variables ........ %(0), %(0), %(0)
    
    VALUES ====================================  SEQ_NO 1    NO CHILDREN
    DESCRIPTION
      fragment_id ............ 0
      parent_frag ............ (none)
      fragment_type .......... master
      tuple_expr ............. %(0)
    
    --- SQL operation complete.
    >>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anoopsharma00/incubator-trafodion ansharma_explain_br

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/1179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1179
    
----
commit 5a244d532425a6a4aff19a5cd2cd6ab637ea9b0a
Author: Anoop Sharma <anoop.sharma@esgyn.com>
Date:   2017-07-14T04:18:03Z

    Few fixes, details listed below.
    
    -- fix an issue where multiple values inserted from a list would return
      error but each value inserted on its own would succeed.
      ex: create table ts (a timestamp);
          insert into ts values ('2017-01-01 10:10:10'), ('2018-01-01 10:10:10');
    
    -- sometimes errors returned from child during hive inserts were not
       being returned. That has been fixed.
    
    -- TRAFODION-2683 extension.
       added a 'p' (prune) option which would cleanse and filter unneeded
       explain output. This helps in reducing output especially
       for larger explains.
    Ex:
    >>explain option 'p' select * from dual;
    
    ------------------------------------------------------ PLAN SUMMARY
    STATEMENT_NAME ........... NOT NAMED
    STATEMENT ................ select * from dual;
    
    ------------------------------------------------------- NODE LISTING
    ROOT ======================================  SEQ_NO 2    ONLY CHILD 1
    DESCRIPTION
      fragment_id ............ 0
      parent_frag ............ (none)
      fragment_type .......... master
      xn_access_mode ......... read_only
      auto_query_retry ....... enabled
      embedded_arkcmp ........ used
      select_list ............ %(0)
      input_variables ........ %(0), %(0), %(0)
    
    VALUES ====================================  SEQ_NO 1    NO CHILDREN
    DESCRIPTION
      fragment_id ............ 0
      parent_frag ............ (none)
      fragment_type .......... master
      tuple_expr ............. %(0)
    
    --- SQL operation complete.
    >>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message