trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1202: [TRAFODION-2703] Add *Load XML Files...
Date Mon, 14 Aug 2017 20:44:10 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1202#discussion_r133055159
  
    --- Diff: docs/odb_user/src/asciidoc/_chapters/load.adoc ---
    @@ -637,6 +637,64 @@ odb considers the string following the “em” character as the
path of the fil
     
     NOTE: odb does not load rows where the size of the input file is greater than the target
database column.
     
    +[[load_xml_files]]
    +== Load XML Files
    +Trafodion odb supports loading xml files into tables, the key construct for xml files
can be an element or an attribute.
    --- End diff --
    
    XML is an acronym (eXtensible Markup Language), and so should be capitalized when it appears
in prose. If it appears as a file extension (for example, xyz.xml) or as part of a code example
then lower case is fine. Also, this appears to be a run-on sentence. Better perhaps would
be "Trafodion odb supports loading XML files into tables. The key construct for XML files
may be an element or an attribute."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message