trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1206: [TRAFODION-2617] Optionally push est...
Date Tue, 15 Aug 2017 21:58:53 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1206#discussion_r133314975
  
    --- Diff: core/sql/sqlcomp/nadefaults.cpp ---
    @@ -1759,6 +1763,7 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS,		"OFF"),
      // exposure.
      DDkwd__(HBASE_DELETE_COSTING,		             "ON"),
      DDflt0_(HBASE_DOP_PARALLEL_SCANNER,             "0."),
    + DDkwd__(HBASE_ESTIMATE_ROW_COUNT_VIA_COPROCESSOR,   "OFF"),
    --- End diff --
    
    I can buy that. May I suggest that we leave the old code there for the moment until this
can be thoroughly exercised? I can remove the old code in a later check-in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message