trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1216: TRAFODION-2724
Date Thu, 24 Aug 2017 04:50:29 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1216#discussion_r134926173
  
    --- Diff: core/sql/exp/ExpLOBaccess.cpp ---
    @@ -1970,7 +1970,14 @@ Ex_Lob_Error ExLob::readCursorData(char *tgt, Int64 tgtSize, cursor_t
&cursor, I
                   continue;
              }
           }
    -      
    +      if (operLen == tgtSize)
    +        {
    +          //The cursor still has data available but wait until redrive since
    +          //we have fetched all the data for this extract operation
    --- End diff --
    
    The cursor on the full lob data indicates that there is data left. But the extract operation
can retrieve justt a portion of the total. The state is maintained in the cursor and will
get updated with each "execute" of the extract statement issued by caller of the extract statement.
 Agree this comment is confusing. I can just say "return the  data to caller". 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message