trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From luoyunpeng <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1213: implement isValid function
Date Thu, 24 Aug 2017 05:22:06 GMT
Github user luoyunpeng commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1213#discussion_r134928929
  
    --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4Connection.java ---
    @@ -1876,9 +1876,57 @@ public SQLXML createSQLXML() throws SQLException {
     		return null;
     	}
     
    -	public boolean isValid(int timeout) throws SQLException {
    -		// TODO Auto-generated method stub
    -		return false;
    +    public boolean isValid(int timeout) throws SQLException {
    +        if (props_.t4Logger_.isLoggable(Level.FINE) == true) {
    +            Object p[] = T4LoggingUtilities.makeParams(props_);
    +            props_.t4Logger_.logp(Level.FINE, "TrafT4Connection", "isValid", "iValid",
p);
    +        }
    +        if (props_.getLogWriter() != null) {
    --- End diff --
    
    no,  the log will only be written when user of client set the log level to true and log
writer is not null,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message